Skip to content

Console.WriteLine -- updating for Try .NET #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2019

Conversation

WilliamAntonRohm
Copy link
Contributor

samples PR is dotnet/samples#1641

@WilliamAntonRohm
Copy link
Contributor Author

@mairaw, @BillWagner -- please review these updates.

@mairaw mairaw closed this Oct 18, 2019
@mairaw mairaw reopened this Oct 18, 2019
@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Oct 22, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WilliamAntonRohm. Left a comment for you to address.

@@ -5666,6 +5666,8 @@
## Examples
The following example demonstrates the standard formatting specifiers for numbers, dates, and enumerations.

[!INCLUDE[interactive-note](~/includes/csharp-interactive-note-some.md)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the note should be included in the top of the page instead (membergroup element remarks - line 4725)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@mairaw mairaw added this to the October 2019 milestone Oct 23, 2019
@mairaw mairaw closed this Dec 4, 2019
@mairaw mairaw reopened this Dec 4, 2019
@mairaw
Copy link
Contributor

mairaw commented Dec 4, 2019

Need a fresh build to validate

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @WilliamAntonRohm!

@mairaw mairaw merged commit 272c1d3 into dotnet:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vendor-project Indicates the issue/pr is related to a vendor project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants